‘Saving as’ an ASM File then Exiting the Program Leads to a Crash

Windows 7, 32
SimulIDE-R1861_Win32.

I liked to add a new function to ‘EarTest_08T4.asm’ (the name is not important). So, after I opened it, I saved it with another name as 'EarTest_08T5.asm'. Then, without doing anything else, I closed/exited simulIDE. A crash occurred.

I repeated these few steps several times and I got a crash always.

I hope this can be reproduced on your side.
(You may like to open ‘EarTest_08P_.asm’, you have already, and rename it as ‘EarTest_08PP.asm’ for example, then exit the program).

Please note that your fix of EEWE is not done for ATmega32 (and perhaps it is not done for some other MCUs in its family).

https://simulide.forumotion.com/t1064-about-working-with-avrasm2-assembler#4683

KerimF wrote:Windows 7, 32
SimulIDE-R1861_Win32.

I liked to add a new function to ‘EarTest_08T4.asm’ (the name is not important). So, after I opened it, I saved it with another name as 'EarTest_08T5.asm'. Then, without doing anything else, I closed/exited simulIDE. A crash occurred.

I repeated these few steps several times and I got a crash always.

I hope this can be reproduced on your side.
(You may like to open ‘EarTest_08P_.asm’, you have already, and rename it as ‘EarTest_08PP.asm’ for example, then exit the program).

It seems that it's because the old filename is not removed from the m_fileList in the editorwidget::saveas().

I've made a patch.

And also an issue I found:
- Some codeeditors may not get closed in the editorwidget::close(). Because when a tab/codeeditor is removed, m_docWidget->count() will decrease. So use icount() as the loop condition will cause the loop to be terminated early.

Thanks KerimF.

And also an issue I found:
- Some codeeditors may not get closed in the editorwidget::close(). Because when a tab/codeeditor is removed, m_docWidget->count() will decrease. So use icount() as the loop condition will cause the loop to be terminated early.

Here is where i get the crash.
Solved at Rev 1873.

It seems that it's because the old filename is not removed from the m_fileList in the editorwidget::saveas().

I didn't solve this one, but definetly can cause problems.
If you already have a solution, I will wait for your patch.

arcachofo wrote:Thanks KerimF.

And also an issue I found:
- Some codeeditors may not get closed in the editorwidget::close(). Because when a tab/codeeditor is removed, m_docWidget->count() will decrease. So use icount() as the loop condition will cause the loop to be terminated early.

Here is where i get the crash.
Solved at Rev 1873.

It seems that it's because the old filename is not removed from the m_fileList in the editorwidget::saveas().

I didn't solve this one, but definetly can cause problems.
If you already have a solution, I will wait for your patch.

It seems that I forget the patch

royqh1979 wrote:It seems that I forget the patch

Patch (partially) applied at Rev 1876.

royqh1979 wrote:And also an issue I found:
- Some codeeditors may not get closed in the editorwidget::close(). Because when a tab/codeeditor is removed, m_docWidget->count() will decrease. So use icount() as the loop condition will cause the loop to be terminated early.

I changed this a bit (R1873):
I will close all or nothing (if cancelled).

arcachofo wrote:

royqh1979 wrote:It seems that I forget the patch

Ptach (partially) applied at Rev 1876.

royqh1979 wrote:And also an issue I found:
- Some codeeditors may not get closed in the editorwidget::close(). Because when a tab/codeeditor is removed, m_docWidget->count() will decrease. So use icount() as the loop condition will cause the loop to be terminated early.

I changed this a bit (R1873):
I will close all or nothing (if cancelled).

It seems that close() is still not correct.
The first loop still not correctly loop all the codeeditors.
And the second loop forcely close all lefted. This may cause some codeeditors not saved before close.

Code:


    for( int i=0; i<m_docWidget->count(); i++ )
    {
        m_docWidget->setCurrentIndex( i );
        if( !maybeSave() ) return false;
    }
    while( m_docWidget->count() )
    {
        m_docWidget->setCurrentIndex( 0 );
        closeTab( 0 );
    }


It seems that close() is still not correct.
The first loop still not correctly loop all the codeeditors.
And the second loop forcely close all lefted. This may cause some codeeditors not saved before close.

I don't see why the first loop still not correctly loop all the codeeditors.
And the second loop is reached only if everything was saved.

arcachofo wrote:

It seems that close() is still not correct.
The first loop still not correctly loop all the codeeditors.
And the second loop forcely close all lefted. This may cause some codeeditors not saved before close.

I don't see why the first loop still not correctly loop all the codeeditors.
And the second loop is reached only if everything was saved.

oh, I see. Codeeditors are not removed in the first loop.

oh, I see. Codeeditors are not removed in the first loop.

Exactly.
In any case is more efficient to read the size only once.