My zoom doesn't work

I'm trying to understand how the zoom works.
I did a simple test but the result is not what I was hoping for.
I search for an example component "rectangle-1" and then apply fit to view:

   Component* bordo = Circuit::self()->getComponent("Rectangle-1");
   fitInView(bordo, Qt::KeepAspectRatio);

I start from new0.png


I would like to get new1.png




but I get new2.png


Where am I wrong?
Greetings

To see how zoom currently works have a look at CircuitView::wheelEvent().

You probably need to set the scale back to 1, then fitInView:

Code:


    Component* bordo = Circuit::self()->getComponent("Rectangle-1");

    resetMatrix();
    m_scale = 1;

    fitInView(bordo, Qt::KeepAspectRatio);


I did some tests and got some results with this code:

Code:


       fitInView(m_circuit->itemsBoundingRect(), Qt::KeepAspectRatio);
       scale( 0.27061, 0.27061 );


I enlarge a rectangle that contains the components present in the window (as a dimension), not where the components are but the upper left vertex coincides with the upper left vertex of the window.
If the objects are in the upper left area it works, if they are in another area the view is empty in the upper left corner.
I would like the upper left corner of the window to coincide with the upper left corner of the rectangle returned by itemsBoundingRect () as fi can do.
Greetings

I think m_circuit->itemsBoundingRect() returns a rectangle in QGraphicsScene coordinates, that is: relative to circuit canvas.
You probably need to map that rectangle to QGraphicsView coordinates.
Have a look at: https://doc.qt.io/qt-5/qgraphicsview.html#mapFromScene

Subcircuits give me an itemsBoundingRect ()
much larger than necessary see image:



it is possible to avoid it.
Greetings

To see what is causing the problem in that subcircuit, can you do this? :

Comment out line 292 at src/gui/circuitwidget/subcircuit.cpp :
//comp->setHidden( true, true );

Then take an screenshot with that subcircuit in the scene.

I was doing tests on version 0.4.15.
Version 1.0.0 does not have this problem.
I have eliminated the problem from 0.4.15 by copying from 1.0.0.
I have implemented a slot that performs a simple zoom all
also works on version 1.0.0, there will definitely be a
better way but I have not found examples on the net.

Code:


circuitview.cpp

QAction* ZoomAllAction = menu.addAction( QIcon( ":/zoomall.png"),tr("ZoomAll") );
        connect( ZoomAllAction, SIGNAL( triggered()), this, SLOT(slotZoomAll()) );


void CircuitView::slotZoomAll()
{
      resetTransform();
      m_circuit->update();
      updateSceneRect(sceneRect());
      QRectF rectframe = frameRect();
      qreal a_ratio = rectframe.width() / rectframe.height();
      QRectF rectitem = m_circuit->itemsBoundingRect();
      QPointF p0 = rectitem.topLeft();
      qreal rectitem_H = rectitem.height();
      qreal rectitem_W = rectitem.width();
      if (rectitem_W / rectitem_H > a_ratio) {
          rectitem_H = rectitem_W / a_ratio;
      }
      else {
          rectitem_W = rectitem_H * a_ratio;
      }
      qreal val = (3200 / rectframe.width() + 2400 / rectframe.height()) / 2.0;
      QRectF rectall = QRectF(p0.x(), p0.y(), rectitem_W * val, rectitem_H * val);
      if (!rectitem.isEmpty()) {
          fitInView(rectall, Qt::KeepAspectRatio);
          m_circuit->setSceneRect(m_circuit->itemsBoundingRect());
      }
      else {
          m_circuit->setSceneRect(QRect(-1600, -1200, 3200, 2400));
          scale(0.27, 0.27);
      }
}


Greetings

The problem is that this breaks zoom and pan:
m_circuit->setSceneRect(m_circuit->itemsBoundingRect());

But I found the actual cause why fitInView() is not working.
I solved that issue and added Zoom to Fit at Rev 897.

Now this is working:

Code:

void CircuitView::slotZoomAll()
{
    QRectF r = m_circuit->itemsBoundingRect();
    fitInView( r, Qt::KeepAspectRatio );
}