Component's label is not unique on copy and paste

Component's label should be unique in the project to identify the component?
For instance, DS18B20-X, where X is the unique number in the project?

I have notice that when copy and paste one component (particularly noticed with DS18B20), the component's label stay the same, This makes a bit of confusion in debug console if used - exact device cannot be identified, thus have to be manually changed.

Solved at Rev 1169.

New ROM ID should be generated on copy and paste as well, for DS18B20...

I see... the ROM generated in constructor is overwritten with the ROM of the copied.

But when you do a copy it's a copy.
I think that if you need a new ROM better getting a new component instead of copy paste.

I understand, however that is not practical. Should be a way to override this special case... . ROM ID is unique for each 1-wire device.

I have tried to test 63 devices on the same bus, but 60 during copy and paste retained the same ROM ID.

Well, if not possible, it is not possible...

Wait... there is a very simple way:
I didn't remember, but the component can know if the circuit is doing a paste operation and avoid the overwrite.
I think it should work and you can do it easily:

Code:

void Ds18b20::setROM( QString ROMstr )
{
    if( Circuit::self()->pasting() ) return; /// ADD THIS LINE
    
    bool ok;
    QStringList lstROM = ROMstr.split(" ");
    lstROM.removeAll("");
    for( int i=0; i<8; ++i ) m_ROM[i] = lstROM.at( i ).toInt( &ok, 16 );
    qDebug() << idLabel() <<"Ds18b20::setROM"<<arrayToHex( m_ROM, 8 );
}

Also Ds18b20 should have an static list of ROMs already in the circuit.
And Ds18b20::generateROM should  check if the new ROM generated is already in use, if not generate a new one.
Then add the new ROM to the list.

What do it now is paste one component with new ROM ID, however, the rest is clean copy of that with the same, newly created ROM ID.

I.e. If there is 6 devices, copy and paste all 6 gives only 7 unique ROM ID devices, instead all 12...

I.e. If there is 6 devices, copy and paste all 6 gives only 7 unique ROM ID devices, instead all 12...

It gives unique new ROMs for me.
The original 6 devices had the same ROM?

arcachofo wrote: The original 6 devices had the same ROM?

No, they are all unique...

But I have involved srand(time(0)) to get more unique ID, but whole paste procedure is too fast to get unique seed... Just remove it and it works fine now. Sorry.